mclag enhancements as per HLD at Azure/SONIC#596 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2020
This was referenced Oct 30, 2020
| ) | ||
|
|
||
| func init() { | ||
| XlateFuncBind("YangToDb_mclag_domainid_fld_xfmr", YangToDb_mclag_domainid_fld_xfmr) |
There was a problem hiding this comment.
Why these field-transformers like (YangToDb_mclag_domainid_fld_xfmr) is required, since openconfig-mclag-annot.yang is not part of this PR? Also couldn't see any other open PR for that OC-yang mclag extension. Also KLISH cmds in other PR (sonic-net/sonic-mgmt-framework#59) uses sonic-yang for configuration
prvattem
reviewed
Nov 11, 2020
| "strconv" | ||
| "strings" | ||
| "translib/db" | ||
| "translib/ocbinds" |
There was a problem hiding this comment.
Are you using openconfig-yang models?
There was a problem hiding this comment.
yes, will udpate oc yang along with this PR
gitsabari
force-pushed
the
mclag_enhacements
branch
from
0380abb
to
35e4e13
Compare
|
since sonic-yang files got moved to sonic-buildimage removing this PR as this doesn't hold good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR contains the code changes to support management framework changes for mclag enhancements as per HLD sonic-net/SONiC#596
Why I did it
Implemented as per the MCLAG enhancements HLD: sonic-net/SONiC#596
How I verified it
Mclag specific VS tests included part of check-in.
Details:
The PR includes management framework changes part of MCLAG enhancements
This PR must work with submitted PR's in other sonic repositories which are listed below.
> Iccpd: sonic-net/sonic-buildimage#4819
> Swss: sonic-net/sonic-swss#1331
> swss-common: sonic-net/sonic-swss-common#405
> Mclagsyncd: sonic-net/sonic-swss#1349
> Utilities: sonic-net/sonic-utilities#1138
> Mgmt-FW: sonic-net/sonic-mgmt-framework#59